search

kessler / license-report

create a short report about a project's dependencies (license, url etc)
MIT License
236 stars 39 forks source link

Fix for package name, when it contains @ symbol #7

Closed ihorgor closed 7 years ago

ihorgor commented 7 years ago

Hello, Yes, I'm trying to check if name starts with "@" I'm java developer and didn't do any experience with JS, that's why I did it in such way.

2017-05-24 15:25 GMT+03:00 Yaniv Kessler notifications@github.com:

@kessler requested changes on this pull request.

In index.js https://github.com/ironSource/license-report/pull/7#discussion_r118237038 :

@@ -114,7 +114,9 @@ function addAll(packages, packageIndex) {

// iterate over packages and prepare urls before I call the registry for (var p in packages) {

  • if(p.indexOf("@") == 0) {

I never use == in my code. Also I'm not sure I understand, you're checking if the package name starts with @ ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ironSource/license-report/pull/7#pullrequestreview-40007915, or mute the thread https://github.com/notifications/unsubscribe-auth/AVY0TaJXAMnno4_ZgaobIwFN5Jq-zlYDks5r9CHSgaJpZM4LTH0q .