kessler / node-regedit

Read, Write, List and do all sorts of funky stuff to the windows registry using node.js and windows script host
MIT License
277 stars 45 forks source link

using \uXXXX to encode unicode string #1

Closed tengattack closed 9 years ago

tengattack commented 9 years ago

Hi, I'm trying using \uXXXX to encode unicode string It will be useful in non-English system.

Thanks.

kessler commented 9 years ago

Hi

Would it possible for you to include a test case for this? (see https://github.com/ironSource/node-regedit/blob/master/test/regedit.test.js)

Thank you very much for contributing!

Kessler

tengattack commented 9 years ago

@kessler hi, I try add some non-English characters to the tests Are these enough for the JSON Unicode encode test?

teng

tengattack commented 9 years ago

If I remove the JsonU function, the test will failed like this: But this will have a related with character encoding of the command line, I have set it to 65001 (UTF-8) by default.

failed message

kessler commented 9 years ago

I just tested it and its ok! :+1: