Make the VBS folder path changable

[muminasaad]

In some cases having the VBS under node_modules will make the application fail due to that changing the path of the VBS folder path is required

[kessler]

Sorry for the late late late attention to this PR. Can you please explain why would you want an external VBS folder?

[muminasaad]

Dear Yaniv,

I was working with Electron, so the electron application couples all dependencies in one file called app.asar, after coupling this files the module couldn't locate the VBS files because they are compressed in one file. So the solution was that the VBS folder to go somewhere out of the modules folder and to a shared location, thats why i needed an external VBS folder.

This problem is reproduced with multiple cases and reported as a bug for some people

On Fri, Dec 1, 2017 at 4:30 AM, Yaniv Kessler notifications@github.com wrote:

Sorry for the late late late attention to this PR. Can you please explain why would you want an external VBS folder?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ironSource/node-regedit/pull/47#issuecomment-348383998, or mute the thread https://github.com/notifications/unsubscribe-auth/AFtMbUAU-tDWff16aXXPXbeIy0CZ9dkJks5s72S_gaJpZM4PUMuq .

[Taxel]

@kessler Is this PR going to be merged soon? Otherwise, I will have to fork it, since I have the same Problem ( Error: Command failed: cscript.exe //Nologo PATH_TO_APP\resources\app.asar\node_modules\regedit\vbs\regList.wsf A HKLM\SOFTWARE) @muminasaad could you further elaborate your fix, please? As I understand it:

• Copy VBS folder from /node_modules/regedit to a different one (let's say /assets/vbs)
• Add that vbs folder to the build includes if necessary (I am having this problem in electron-builder)
• Reference the new vbs folder from the modified script Is this correct?

[kessler]

@Taxel I requested the changes, but honestly I didn't check back. Let's see what @muminasaad has to say about my request. If he don't respond soon I'll try to merge it myself

[muminasaad]

@Taxel You understand perfectly. you need to manually copy the vbs files to folder that can be accessed from cmd, then call the setExternalVBSLocation function to change the VBS files location.

@kessler I dont understand what you mean with requesting the changes if can explain more i would be gratefull :)?

[kessler]

@muminasaad I see now I started the review but did not submit it, my bad! here you go

[kessler]

Published to npm in version 3.0.0