kestasjk / webDiplomacy

Play Diplomacy online
http://webdiplomacy.net/
GNU Affero General Public License v3.0
180 stars 113 forks source link

Update fullInstall #835

Open BecketTrotter opened 1 year ago

BecketTrotter commented 1 year ago

Update fullInstall to include the missing final command from 1.7.0-1.7.1

BecketTrotter commented 1 year ago

this fixes docker-compose up -d from not working out of the box for me

lightvector commented 1 year ago

Does this actually work for you with only this fix? I'm actually getting a different error from fullInstall a few lines up:

ALTER TABLE `wD_Groups`
    CHANGE COLUMN `type` `type` VARCHAR(50) NOT NULL DEFAULT 'Unknown' AFTER `name`,
    ADD COLUMN `timeMessageRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeWeightingRequired`;
ALTER TABLE `wD_GroupUsers`
    ADD COLUMN `isDirty` BIT(1) NOT NULL DEFAULT 0 AFTER `timeCreated`,
    ADD COLUMN `messageCount` SMALLINT UNSIGNED NOT NULL DEFAULT 0 AFTER `isDirty`,
    ADD COLUMN `timeLastMessageSent` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `messageCount`,
    ADD COLUMN `timeWeightingRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeLastMessageSent`,
    ADD COLUMN `timeMessageRequired` BIGINT UNSIGNED NULL DEFAULT NULL AFTER `timeWeightingRequired`;

In particular, that wD_Groups does not have a timeWeightingRequired column. This line looks to be copied from the line updating wD_GroupUsers. I it intended that both wD_Groups and wD_GroupUsers have this update? wD_Groups does not have this failing line in the 1.70-1.71 update script.

BecketTrotter commented 1 year ago

@lightvector I have been docker exec'ing into the Mariadb container and applying the change manually to the DB. I figured adding it to fullinstall would fix it out of the box.

I have not ran into that timeWeightingRequired error.