kester-ng / pe

0 stars 0 forks source link

[DG] Class diagram very complicated, can be broken down into separate diagrams #16

Open kester-ng opened 4 years ago

kester-ng commented 4 years ago

The class diagram has many classes ~28 classes And the associations (eg the arrows, lines) tend to cross over each other which makes reading and intepreting the class diagram not very easy.

See SS for details

Screenshot 2020-04-17 at 3.31.17 PM.png

nus-pe-bot commented 4 years ago

Team's Response

The model diagram is not unnecessarily complicated. It shows an overview of the app structure, of which the main model classes include customer, product and transaction features. As such, they are represented in the diagram.

You mentioned that we should 'not detail every single component' but the fact is that we did not detail every single component. For example, we did not include many other features that we have such as the numerous predicates, and quantity threshold classes even though they are part of our model classes. Moreover, we simplified the quantity class by not showing ProductQuantity and TransactionQuantity, instead representing them as Quantity.

If we were to simplify this even more, the only way I can think of would be having only Transaction, Customer and Product classes, and to remove the components in these classes, a.k.a remove Name, Phone, Description etc. This would not be useful as we will only know that there are 3 main model classes in the app but we do not know what these main classes consist of. Even AB3 has shown the components of Person e.g. Name, Address, so I don't see why we cannot.

As such, we believe that this should not be a bug since the diagram details only the necessary and main components of our app.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]