kestra-io / docs

Documentation for Kestra — an event-driven, language-agnostic orchestration and scheduling platform to manage millions of workflows declaratively in code.
https://kestra.io/docs
67 stars 59 forks source link

Some plugin icons are black on dark website — find icons that work on both light and dark mode #1294

Closed brian-mulier-p closed 2 weeks ago

brian-mulier-p commented 4 months ago

Describe the issue

https://kestra.io/plugins/plugin-script-shell/tasks/scripts/io.kestra.core.tasks.scripts.bash

Icons should be in light version so they are properly visible

Environment

wrussell1999 commented 4 months ago

These need a light version: https://github.com/kestra-io/kestra/tree/develop/core/src/main/resources/icons

wrussell1999 commented 3 months ago

@shrutimantri has made a number of PRs to convert these. However, I've realised that we need these icons to work in dark and light mode as they are also used in the Kestra UI (which can be either).

Shruti's tweaks make it so they do work on a light background but not as well as a dark icon would. I've merged one but holding off with the realisation of working on both.

https://github.com/kestra-io/plugin-jdbc/pull/306 https://github.com/kestra-io/plugin-scripts/pull/146 https://github.com/kestra-io/plugin-openai/pull/26 https://github.com/kestra-io/plugin-fs/pull/126 https://github.com/kestra-io/plugin-serdes/pull/113

brian-mulier-p commented 3 months ago

@shrutimantri please instead do this

You need to update the icon to handle black / white theme, example of wrong one, good one. The main difference is : fill="currentColor"
that allow to change the color of the svg. Please take care of this?

brian-mulier-p commented 3 months ago

Can we revert the one you merged @wrussell1999

wrussell1999 commented 3 months ago

Reverted https://github.com/kestra-io/plugin-serdes/pull/114

anna-geller commented 2 weeks ago

will be done as part of https://github.com/kestra-io/kestra/issues/4154 because we will be able to change SVG icon colors via code (e.g. revert colors)