kestra-io / helm-charts

Apache License 2.0
37 stars 26 forks source link

Expose Metric Service #44

Closed kaliazur closed 4 months ago

kaliazur commented 4 months ago

Feature description

Hi, I want to export the metrics using an opentelemetry service in my k8s. But the kestra-standalone deployment does not expose a service for the metric in :8081/prometheus I found a workaround using the kubectl expose deployment ... to make that happen, but it's not really clean and difficult to automate. Do you think you could implement a service: section in the values.yaml ( or something like that ) to create a service that achieve this purpose ? Thank you

loicmathieu commented 4 months ago

We can conditionally expose the management endpoint in the service with a property disabled by default if it is needed.

kaliazur commented 4 months ago

Allright ! Do you mean that it's possible right now ? Like there is a way to do so ? Or do you mean it could be a next feature ? Thank you for your fast answer ! :muscle:

loicmathieu commented 4 months ago

Each pod has a port named management but this port is not available in the service. We would need to implement a new feature to add this port to the service based on a property in the values file.

kaliazur commented 4 months ago

Thank you for your answer @loicmathieu ! :muscle: I wanted to make the modification, and create a PullRequest, but I cannot push in the repo due to a Permission Denied. What is the process to contribute ? Thank you again

loicmathieu commented 4 months ago

@kaliazur this would be great!

You need to fork the repo, create a branch in your own fork, and create a pull request.

kaliazur commented 4 months ago

Roger that @loicmathieu ! Thanks ! I created a Pull Request with those changes

loicmathieu commented 4 months ago

Done in https://github.com/kestra-io/helm-charts/pull/45