kestra-io / kestra

:zap: Workflow Automation Platform. Orchestrate & Schedule code in any language, run anywhere, 500+ plugins. Alternative to Zapier, Rundeck, Camunda, Airflow...
https://kestra.io
Apache License 2.0
13.25k stars 1.15k forks source link

Jumping to Definitions in a plugin documentation will lead to page reload risking unsaved work #5702

Open anna-geller opened 4 weeks ago

anna-geller commented 4 weeks ago

Describe the issue

We should ensure that navigating to any definition doesn't cause a page reload. Otherwise, there's rsk of unsaved work for the user or they would need to save unnecessarily often.

Demo: https://share.descript.com/view/A33LTwKq1C6

To reproduce, navigate to the definition linked on the storeManifest property in the dbt plugin:

id: dbt_build
namespace: company.datateam.dbt

tasks:
  - id: dbt
    type: io.kestra.plugin.dbt.cli.DbtCLI
    namespaceFiles:
      enabled: true
    taskRunner:
      type: io.kestra.plugin.scripts.runner.docker.Docker
    containerImage: ghcr.io/kestra-io/dbt-duckdb:latest
    commands:
      - dbt build --project-dir dbt

Environment

shivanshsharma13 commented 3 weeks ago

Hi @anna-geller @MilosPaunovic greetings!, let me try to fix this issue!

MilosPaunovic commented 3 weeks ago

Absolutely, go ahead @shivanshsharma13! 🚀

shivanshsharma13 commented 1 week ago

Hi, apologies for the late notice. I'm currently tied up with office work, so I'll need to unassign myself from this task to allow someone else to take over. I look forward to contributing more when my schedule permits. Thanks for your understanding and patience!🙂