search

kestra-io / kestra

:zap: Workflow Automation Platform. Orchestrate & Schedule code in any language, run anywhere, 500+ plugins. Alternative to Zapier, Rundeck, Camunda, Airflow...
https://kestra.io
Apache License 2.0
12.97k stars 1.13k forks source link

Executions filter still is applied even if user canceled it #5875

Open smunteankestra opened 6 days ago

smunteankestra commented 6 days ago

Describe the issue

Step 1 : Add a filter Step 2 : remove it by pressing the X cross on it Step 3: Refresh Expected: filter to be removed Actual: Filter remains

https://github.com/user-attachments/assets/73e7d166-3931-4e92-9b86-94f4a8474797

Environment

sarthakvijayvargiya commented 6 days ago

Hi @MilosPaunovic Can i work on this.

MilosPaunovic commented 6 days ago

You can, but as this is a part of our new filters overhaul, I'll take over tomorrow if there's no PR submitted by then.

New filters are now shown only on Executions page (that is the name of the component, as well) so you can start there.

MilosPaunovic commented 5 days ago

So, I've looked at this, and, as of this moment, it is expected behavior, as the search is being triggered only when we click the search button to the right.

We can update the expected outcome for the filters to be updated every time we remove a tag, like Stefan did here. Is that what we want from the product perspective @Ben8t?

Ben8t commented 5 days ago

Yes, I think the expected behavior from Stephan is the good one. Can we apply this to only "remove" action and not "add filter" (seeing the UI blinking every time a user add a filter doesn't sounds right in this case).

FYI, on GitHub Project filter, everything is applied at every change... (which make the UI blink a lot; not very UX friendly IMO, especially on adds)

MilosPaunovic commented 5 days ago

Agreed, will make the necessary change.

MilosPaunovic commented 5 days ago

Even better, @sarthakvijayvargiya, are you willing to have this as your first contribution, with a bit of help from my side?

You need to edit the kestra/ui/src/components/filter/KestraFilter.vue component and add this router.push({query: encodeParams(current.value)}); to line 269, as part of the removeItem method.

Will wait for your PR if you're up for it?

Piyush-r-bhaskar commented 1 day ago

Hi @MilosPaunovic

I would appreciate the opportunity to open a PR for this if it's fine to proceed now. & I can't see any Wrapper component here kestra/ui/src/components/filter/Wrapper.vue

Thanks

MilosPaunovic commented 3 hours ago

Hi @Piyush-r-bhaskar, we'd like to save this one for one of the new contributors willing to start their OSS journey, as an easy win for the beginning. You are already our well versed Kestra contributor, so we're safe with you approaching more complex topics, if that's alright with you?

Also, there was some refactoring from the time this issue was created, so the component in question is now renamed to kestra/ui/src/components/filter/KestraFilter.vue (will change in the initial response, just to avoid confusion).