search

kestra-io / kestra

:zap: Workflow Automation Platform. Orchestrate & Schedule code in any language, run anywhere, 500+ plugins. Alternative to Zapier, Rundeck, Camunda, Airflow...
https://kestra.io
Apache License 2.0
13.25k stars 1.15k forks source link

Killing workflow executions does not work if workflow is in Retry #5983

Open johnkm516 opened 1 week ago

johnkm516 commented 1 week ago

Describe the issue

I have not tested this without subflows, therefore I do not know if this issue is exclusive to a parent workflow executing child workflows that are in retry, or if this issue exists regardless.

1) Create a parent workflow that executes a child workflow. 2) Have the child workflow cause an error with a retry, for example 5 times with an interval of 10s. 3) While the child workflow is in retry, kill the parent execution (Kill parents and subflows, or kill the parent, either or it doesn't work). 4) The parent and child workflow executions are not killed. The retry logic overrides the kill command and keeps executing.

Environment

Ben8t commented 6 days ago

Hello John, I'm not able to reproduce on kestra:develop. See the following flow and screenshot

id: parent
namespace: kestra.test

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

  - id: subflow
    type: io.kestra.plugin.core.flow.Subflow
    flowId: child
    namespace: kestra.test
id: child
namespace: kestra.test

tasks:
  - id: retry
    type: io.kestra.plugin.scripts.shell.Commands
    commands:
      - sleep 5
      - exit 1
    retry:
      type: constant
      interval: PT10M
      maxAttempt: 5
    taskRunner:
      type: io.kestra.plugin.core.runner.Process

image

image

Can you provide flows to reproduce (if mines aren't complete) and screenshot please ?