Disable the Execute button if inputs don't pass validation - e.g. email input type - Githubissues

kestra-io / kestra

:zap: Workflow Automation Platform. Orchestrate & Schedule code in any language, run anywhere, 500+ plugins. Alternative to Zapier, Rundeck, Camunda, Airflow...

https://kestra.io

Apache License 2.0

13.1k stars 1.15k forks source link

Disable the Execute button if inputs don't pass validation - e.g. email input type #6039

Open anna-geller opened 21 hours ago

anna-geller commented 21 hours ago

Describe the issue

id: kestra_cloud_form
namespace: company.team

inputs:
  - id: email
    type: EMAIL
    displayName: Your e-mail address

  - id: reason
    type: STRING
    displayName: What do you plan to orchestrate?

  - id: accept_tos
    type: BOOLEAN
    defaults: true
    displayName: I agree to receive other communications from Kestra.
    description: By clicking Submit, you agree to Kestra storing and processing the personal information provided above to deliver the requested content.

tasks:
  - id: save_in_db
    type: io.kestra.plugin.core.log.Log
    message: Signup received

Environment

Kestra Version: develop

anna-geller commented 21 hours ago

we need this red Error to be gone 🙃

elevatebart commented 4 hours ago

I love Vitaly Friedman's take on this one. Have you considered that long forms can be confusing?

https://www.smashingmagazine.com/2021/08/frustrating-design-patterns-disabled-buttons/#when-only-a-single-button-is-disabled

There is also Adam Silver describing a few caveats

Could we improve the way we display errors so that "Errors detected" is more useful?

I will disable the button for now, but I think there is a more usable way.