search

kestra-io / plugin-fs

https://kestra.io/plugins/plugin-fs/
Apache License 2.0
6 stars 7 forks source link

feat/samba #87

Closed brian-mulier-p closed 9 months ago

brian-mulier-p commented 9 months ago

closes #23

brian-mulier-p commented 9 months ago

I added some comments but I have no strong opinion on the commons-vfs2 fork, that was already on the branch from @tchiotludo but I think it was mostly for sandbox but as I no longer use that dependency maybe we should go back on that release :thinking:. For the newly added lib I added a comment but basically commons-vfs2 doesn't offer SMB protocol handling (it's only part of their sandbox right now, AKA experimental features which are on another lib). However even that experimental handling from Apache doesn't support SMB2 / 3 while it's what's recommended security wise so I believe it won't be able to be used if we don't use another lib that handles that. The lib I added provides an extra-layer over commons-vfs2's sandbox to add SMB2/3 support

loicmathieu commented 9 months ago

If sandbox is not needed, please use the official release

brian-mulier-p commented 9 months ago

Done