search

kestra-io / plugin-jdbc

https://kestra.io/plugins/
Apache License 2.0
10 stars 7 forks source link

Adjust all Query tasks and Trigger triggers that use store, fetch, fetchOne, fetchSize to use fetchType instead #374

Closed anna-geller closed 2 days ago

anna-geller commented 1 week ago

Feature description

Currently, we do our best to use fetchType in all Query and Trigger implementations: https://kestra.io/plugins/plugin-surrealdb/tasks/io.kestra.plugin.surrealdb.query#fetchtype

However, some older plugins like Postgres use the approach with store, fetch, fetchType and fetchOne properties. To keep it maintainable, it seems best to deprecate those and keep the fetchType for consistency.

mgabelle commented 6 days ago

After taking a quick look I understand that fetchType can be STORE, FETCH, FETCH_ONE, or NONE so it is useful to deprecate store, fetch, fetchType, and fetchOne. But why do we want to deprecate fetchSize ?

Ben8t commented 6 days ago

Indeed fetchSize is needed for fetchType: FETCH. We should keep it for now.

anna-geller commented 6 days ago

thx Ben!