search

kestra-io / plugin-notifications

Apache License 2.0
1 stars 9 forks source link

Add possibility to set read/write timeout for HTTP requests sent from notification plugins #150

Open anna-geller opened 2 months ago

anna-geller commented 2 months ago

Feature description

https://github.com/kestra-io/plugin-notifications/blob/master/src/main/java/io/kestra/plugin/notifications/teams/TeamsIncomingWebhook.java doesn't have options property available in HTTP plugin, it would be great to add it to help users running kestra in slow or unreliable networks.

anna-geller commented 2 weeks ago

@Ben8t assigned you only to coordinate specific next steps here with Matt 👍

Ben8t commented 4 days ago

After analysis from @mgabelle , adding such options is possible on most of notification plugins (as they use the DefaultHttpClient).

mail is another protocol (SMTP) and already have sessionTimeout option. sounds legit to keep it like that

anna-geller commented 2 days ago

sure, let's add it on all that support HTTP incl. Microsoft Teams