search

kestrelquantum / NamedTrajectories.jl

Efficient Handling of Trajectories with User Defined Named Components
MIT License
6 stars 4 forks source link

Add global trajectory parameters #41

Closed ErikQQY closed 1 month ago

ErikQQY commented 1 month ago

Fix: #37

aarontrowbridge commented 1 month ago

hey @ErikQQY the tests failed, looks like a variable should be uppercase, check the comment I left. It looks good otherwise tho! Let's get the tests passing and we'll merge it in.

aarontrowbridge commented 1 month ago

CI is running, last thing @ErikQQY, can you add a docs file in line with the last bullet in the issue #41. :) looks good otherwise 👍

ErikQQY commented 1 month ago

The documentations has been added

ErikQQY commented 1 month ago

bump, if there is still something missing?

aarontrowbridge commented 1 month ago

@ErikQQY sorry, I caught something, and have been under the weather, it is merged in! Thanks so much!

ErikQQY commented 1 month ago

Wishing you all good! Take care!!!