Closed Fe-r-oz closed 3 months ago
Hi, Please review the PR so that the review comments can be addressed before the deadline.
sorry i caught something and have been under the weather so i missed a bunch of stuff. this looks good! thanks @Fe-r-oz
No worries at all, Please take care and get well soon! @aarontrowbridge
This PR aims to Resolve Issue https://github.com/aarontrowbridge/QuantumCollocation.jl/issues/102 and is an improvement over the PR #111
Sorry, my earlier PR #111 was rough. I have made sure this one is nice and clear! This will save your time during the review, @aarontrowbridge and @andgoldschmidt!
I have also newely added test for the newly added
CZ
gates as well!Implementation details are as follows:
docstrings
for all of the functions insrc/quantum_utils.jl
tests
for the functions intest/quantum_utils_test.jl
This PR implements tests for QuantumUtils along with providing docstrings in the
src/quantum_utils.
TestItems creates for the following:
Docstrings include the argument signatures, and a short description. The copiolot stuff is not touched upon in this PR. Only a few relevant commits with complete description are done so make a clear and concise PR.
Testing: Complete testing of the TestItems have done locally. Instead of 19 commits, only few commits is done and files are shortened and redundant comments have been removed.