search

kestrelquantum / QuantumCollocation.jl

Quantum Optimal Control with Direct Collocation
MIT License
29 stars 7 forks source link

QuadraticRegularizer timestep normalization for free time problems #50

Closed andgoldschmidt closed 10 months ago

andgoldschmidt commented 10 months ago

Describe the bug QuadraticRegularizer is called on controls a to limit amplitudes. In a free time problem, the amplitude can be lowered if the timestep is increased. As a result, the pulse duration will only increase to improve regularization cost. The correct QuadraticRegularizer must divide the regularized value by the timestep size.

To Reproduce Run a free time optimization. Compare the initial timestep to the timestep after the optimization. All timesteps will take larger values.

Expected behavior QuadraticRegularizer should keep the control energy small. Amplitude constraints keep the control from exceeding some value.

aarontrowbridge commented 10 months ago

this was revised with PR #55 I believe?

aarontrowbridge commented 10 months ago

should be an integral regulizer, which was added -- closing.