search

kestrelquantum / QuantumCollocation.jl

Quantum Optimal Control with Direct Collocation
MIT License
29 stars 7 forks source link

Objective constructors have bad initial keyword args #63

Closed aarontrowbridge closed 4 months ago

aarontrowbridge commented 10 months ago

Describe the bug Default values for objective constructors used in loading saved objectives have bad values.

Example at line 469 in objectives.jl 

function QuadraticSmoothnessRegularizer(;
    name::Symbol=nothing,
    times::AbstractVector{Int}=1:traj.T,
    R::AbstractVector{<:Real}=ones(traj.dims[name]),
    eval_hessian=true
)
andgoldschmidt commented 4 months ago

closing because duplicate of #68