search

ketanhwr / chain-reaction

Online version of the famous game "Chain Reaction"!
MIT License
36 stars 40 forks source link

Changing the board size #22

Open carpentierriwan opened 6 years ago

carpentierriwan commented 6 years ago

I cloned your project and just did a little refactoring of the code so it uses two variables "horizontalCells" and "verticalCells" rather than hardcoded values for cell size, ball size, ... Which makes it very easy to add some controls to change the board size and things like that. Could I get authority to work on this project?

ketanhwr commented 6 years ago

Sure, go ahead.

prakharcipher commented 6 years ago

I want to pick this issue. May I?

carpentierriwan commented 6 years ago

I have already created it, but I'm still searching on how to upload it here. When I try to push, I get the following: "Authentication failed. You may not have permission to access the repository or the repository may have been archived. Open options and verify that you're signed in with an account that has permission to access this repository."

ketanhwr commented 6 years ago

@carpentierriwan you actually have to fork this repository, clone your fork, and then push into your fork. Then make a pull request.

carpentierriwan commented 6 years ago

@ketanhwr Thanks. I have just created the pull request.

exilednick commented 4 years ago

Is this issue open?