ketanhwr / chain-reaction

Online version of the famous game "Chain Reaction"!
MIT License
36 stars 40 forks source link

Game finish bug #5

Open ketanhwr opened 8 years ago

ketanhwr commented 8 years ago

Sometimes, there are 3 circles in the corner even though the maximum circles are 1 at that point. This is an easy fix.

sranjani-s commented 8 years ago

Is this fixed yet?

ketanhwr commented 8 years ago

@bharg, no.

gin93r commented 8 years ago

Are there steps to easily reproduce this?

ketanhwr commented 8 years ago

I don't know, I've seen it few times only.

abhanshgiri21 commented 7 years ago

i have played many games i cant see this issue @ketanhwr

ketanhwr commented 7 years ago

@abhanshgiri21 I've seen it 2-3 times only

AdamB37 commented 7 years ago

is this still an issue?

ketanhwr commented 7 years ago

@AdamB37 yes.

AdamB37 commented 7 years ago

can you clarify the situation a bit more? based on the rules it explodes when it reaches maximum and the max for a corner is 2 circles then explodes and 3 for on the border but not the corner and 4 everywhere else. What do you mean the maximum is 1 at that point?

ketanhwr commented 7 years ago

If you've played chain reaction, then you'll realise that the maximum number of circles in the corner are 1.

AdamB37 commented 7 years ago

I am new to this game. My understanding you can place one circle in the corner cell and the next time you press the corner cell the circle explodes (due to it becoming two circles) and causes a chain reaction. Before it explodes it shows two circles. Are you saying in the post click, pre explosion duration it shows three circles or does it simply just show three circles and move on to the next turn?

ketanhwr commented 7 years ago

Yes, post explosion this happens.

AdamB37 commented 7 years ago

post explosion? That isn't clear can you please elaborate?

AdamB37 commented 7 years ago

I suspect its an asynchronous issue, but I need to know what the situation looks like to come up with a fix.

Deravadom commented 7 years ago

Is this still up for grabs?

ketanhwr commented 7 years ago

@Deravadom this is still up for grabs, but this issue is a tough one to reproduce. Feel free to find a solution!

dilsheen commented 6 years ago

Can I work on this issue?