ketilmo / balena-ads-b

ADS-B Flight Tracker running on balena with support for FlightAware, Flightradar24, PlaneFinder, OpenSky Network, RadarBox, ADSB Exchange, Wingbits, and UAT.
MIT License
159 stars 43 forks source link

feat: add adsb exchange clones #95

Closed shawaj closed 2 months ago

shawaj commented 1 year ago

Add the following ADS-B Exchange clones:

Also:

Closes: #77 Closes: #78

shawaj commented 1 year ago

Copied comment from #94... At the moment, I am just having a small issue with the MLAT stuff, and I am also going to add the ability to arbitrarily define new services to add (so people can manually do so with environment variables) then will mark as ready for review :-)

shawaj commented 1 year ago

Check the updated readme in my PR :-)

On Mon, 27 Nov 2023, 13:32 Chris Smith, @.***> wrote:

I am getting adsb-exchange ADSB Exchange disabled, skipping. adsb-exchange Adsb.fi disabled, skipping. adsb-exchange Adsb.lol disabled, skipping. adsb-exchange ADS-B One disabled, skipping. adsb-exchange Airplanes.live disabled, skipping. How do i enable them?

— Reply to this email directly, view it on GitHub https://github.com/ketilmo/balena-ads-b/pull/95#issuecomment-1827840557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZUFORB4EOUTDOBK5QXGYTYGSI6ZAVCNFSM6AAAAAA73354J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXHA2DANJVG4 . You are receiving this because you authored the thread.Message ID: @.***>

Teko012 commented 11 months ago

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

shawaj commented 11 months ago

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

@Teko012 did you read the readme... It has options to enable all or enable one by one :-)

shawaj commented 11 months ago

I'll try and get this finished up over the holidays. I got a little bit busy and still need to fix some mlat service error messages

Teko012 commented 11 months ago

I think ENABLE_ALL might be a bit too generic and it can be misleading. I think maybe adding an EXCHANGE_ or some perfix like that could help.

@Teko012 did you read the readme... It has options to enable all or enable one by one :-)

@shawaj Yes, I just think since enable_all only relates to the exchange ones, not to the other ones (fr24, etc...), it's not all services (but it is a device variable on all service, unless you scope it).

shawaj commented 11 months ago

@Teko012 ah i see what you mean. So maybe ADSB_EXCHANGE_ENABLE_ALL or similar you mean?

Teko012 commented 11 months ago

@shawaj Yes, that was my improvement idea :)

shawaj commented 11 months ago

@shawaj Yes, that was my improvement idea :)

Cool, good idea. Will change that in next update

ketilmo commented 11 months ago

Sounds like a great idea. Thanks guys!

Teko012 commented 9 months ago

@shawaj Do you need help to finish this off? :)

shawaj commented 6 months ago

@shawaj Do you need help to finish this off? :)

Sorry, I have been very busy and this dropped down my to do list but should be resuming it soon.

@Teko012 it basically works no problem it is just that I needed to test the MLAT and fix some error messages. Don't think it'll take that long just haven't had time is all.

If you can help at all it would be much appreciated.

ketilmo commented 6 months ago

Looking forward to this. Let me know if you need any assistance in getting this done.

shawaj commented 6 months ago

Looking forward to this. Let me know if you need any assistance in getting this done.

I've got another PR coming in next few days and then it should be done. Been testing locally and seems ok on this end. Then should be good to go

ketilmo commented 6 months ago

Great work, thanks! And thanks to you, @Teko012, for assisting! 👏🏻

shawaj commented 4 months ago

finishing this one up is next on my list :-P

shawaj commented 2 months ago

think this is ready to test @Teko012 @ketilmo

I am still not sure MLAT results are coming through correctly. But I figured perhaps it is best to get this merged and then keep testing. As the basic feeding and MLAT is working and feeding the services.

Not sure what you think.