search

ketiltrout / getdata

The GetData Project is the reference implementation of the Dirfile Standards, a filesystem-based, column-oriented database format for time-ordered binary data.
http://getdata.sourceforge.net/
GNU Lesser General Public License v2.1
4 stars 7 forks source link

Add macOS runner to build workflow #14

Closed arahlin closed 1 week ago

arahlin commented 2 weeks ago

Also include libflac encoding.

ketiltrout commented 1 week ago

This is great! Thanks, Sasha!

But I'm surprised that the test passes because the install_name_tool nonsense is broken (i.e. #5), which I think I have a fix for. Let me see if I can figure out what's going on...

arahlin commented 1 week ago

Yeah I'm not entirely sure why this works either. Maybe because we don't call make install in the runner?

I know there are some partial fixes baked in to the homebrew formula that manually force things to happen in the right order, here: https://github.com/Homebrew/homebrew-core/blob/b045b81aebc4b7f8a952eed78212b930016428c4/Formula/lib/libgetdata.rb

It looks like it's turning off any parallelization when running make, and then installing the trouble perl target before everything else (I think this issue in particular is solved by #6). Also some patch for -flat_namespace issues...

ketiltrout commented 1 week ago

I suspect changing the install order is more a work-around than a fix (if you install all the things, then it doesn't matter that the path mangling doesn't work because everything is where it's supposed to be).

Maybe we should merge this and then I might fiddle around with the CI a bit to see if I can reproduce #5.