search

ketiltrout / getdata

The GetData Project is the reference implementation of the Dirfile Standards, a filesystem-based, column-oriented database format for time-ordered binary data.
http://getdata.sourceforge.net/
GNU Lesser General Public License v2.1
4 stars 7 forks source link

Fix PYTHON_VERSION detection for python 3.10 and higher #7

Closed sbenton closed 1 month ago

sbenton commented 2 years ago

Fix m4 line detecting the PYTHON_VERSION

Formerly used first 3 characters of sys.version string, but this breaks for 2-digit minor versions (eg 3.10 and up) Replace with string containing values from sys.version_info

merny93 commented 1 year ago

Bump.

I tried passing PYTHON_VERSION='3.10' to configure which did not fix the issue.

Work-around by running make then once it fails, cd into the bindings/python/build and rename the directory from ...-3.10 to ...3.1. Finally re-run make and everything worked for me

gsmecher commented 2 months ago

I have tucked this change into PR #11 - please consider merging that one instead. (It fixes more stuff.)

ketiltrout commented 1 month ago

This if fine, I suppose, though I think there are bigger problems with the Python bindings.

sbenton commented 1 month ago

This if fine, I suppose, though I think there are bigger problems with the Python bindings.

Agreed. There are other/newer issues that this PR doesn't address.