Integrate route calculation

ketnek / capstone-project

https://capstone-project-ketnek.vercel.app

0 stars 1 forks source link

Integrate route calculation #4

Open ketnek opened 1 year ago

ketnek commented 1 year ago

Value proposition

As a user, I want to have a route calculation in order to get computed routes based on me selected destinations.

Description

Screenshot 2023-04-27 at 07 29 49

Acceptance criteria

[ ] Selecting a destination via the search input opens a navigation preview.
[ ] The preview shows the route on the map, duration in h and min. and length in km.
[ ] Clicking into the search input opens a keyboard on mobile devices.
[ ] Clicking the arrow in the upper left corner navigate back to the home page.

Tasks

[ ] Create a new feature branch.
[ ] Search the mapbox api to figure out how you can implement the functionality, declared in the acceptance criteria.
[ ] Implement the functionality from mapbox.
[ ] Create button component
[ ] Add a button to get back to the home page.

NikRoe commented 1 year ago

Hi Kevin,

the wireframe shows a navigation bar for which there is no previous user story. The wireframe should only show what current state of the app -> you should remove the navigation bar for now from the wireframe.

You can also consider adding "create button component" to your tasks.

Apart from that, it looks very nice 👍

ketnek commented 1 year ago

Hey Niklas, thanks for your feedback.

You are totally right😁. I didn't saw that. I will remove the navigation bar and add "create button component" to the tasks section.

Roland-Hufnagel commented 1 year ago

Hey Kevin,

I am wondering if clicking the start button will start the navigation in THIS view? I think you don't want it in this view including the input fields at the top. So you can point out a bit more specific what will happen. If you want to start the navigation in another view, I recommend to add this view to your wireframe.

ketnek commented 1 year ago

Hey Roland, thanks for your feedback😃.

I changed my acceptance criteria a bit. Later the Navigation will starts when clicking the button, but for now you are right. I don't want to start the navigation in this view.

Roland-Hufnagel commented 1 year ago

Fine. Then please remove the button from the wireframe. It is no longer needed here. And the point in the acceptance criteria as well.

ketnek commented 1 year ago

Morning,

I've updated the story again. I hope now it is ok :-)

t0bbl commented 1 year ago

as far as i can tell you did everything roland and niklas told you! LGTM

Roland-Hufnagel commented 1 year ago

That's right. Good job now.