ketsuekiro / manialive

Automatically exported from code.google.com/p/manialive
GNU Lesser General Public License v3.0
0 stars 0 forks source link

$window->isVisible() or $window->isShown() ? #37

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In ManiaLib\Gui\Component there is a field $visible and a method isVisible() 
which are supposed to be used in ManiaLive (and are indeed used in 
ManiaLive\Gui\Windowing\Control and in namespace 
ManiaLive\Gui\Windowing\Controls\PageNavigator).
But in Window, a new field $isHidden and a new method isShown() appear and 
$visible doesn't seem to be used anymore...

Problem is now, a lot of plugins with windows use $isHidden and/or isShown()... 
Anyway, I think $isHidden and isShown() should be deprecated ^^

Original issue reported on code.google.com by martin.g...@gmail.com on 20 Jun 2011 at 3:58

GoogleCodeExporter commented 8 years ago
In fact, those two values are not related, in one case it's linked to ManiaLib 
controls, the other one is a value to hide a window in ManiaLive, it's two 
different things.

Original comment by melot.philippe on 29 Jun 2011 at 8:06

GoogleCodeExporter commented 8 years ago
It's still a matter of visibility. BTW, the comment of isVisible() is "This is 
used by ManiaLive." so I don't see any problem to use it for ManiaLive's 
windows ^^

And if those two values are not related, why using posX, posY, posZ, sizeX, and 
so on ? There are linked to ManiaLib controls but used for windows ;)

Original comment by martin.g...@gmail.com on 29 Jun 2011 at 9:40