useResponsiveValue: Fires a side effect on dependency change - Githubissues

kettanaito / atomic-layout

Build declarative, responsive layouts in React using CSS Grid.

https://redd.gitbook.io/atomic-layout

MIT License

1.13k stars 33 forks source link

useResponsiveValue: Fires a side effect on dependency change #327

Closed hallaji closed 4 years ago

hallaji commented 4 years ago

The useResponsiveValue hook does not update the value if one of the dependencies changes. Internationalisation is a good example for this situation.

Changes

Adds a side effect for hook useResponsiveValue

Issues

Closes #326

Release version

[ ] internal (no release required)
[x] patch (bug fixes)
[ ] minor (backward-compatible changes)
[ ] major (backward-incompatible, breaking changes)

Contributor's checklist

[x] My branch is up-to-date with the latest master

[x] I ran yarn verify to see the build and tests pass

hallaji commented 4 years ago

@kettanaito Hey Artem, Are you accepting pull requests on this repo?

kettanaito commented 4 years ago

Hey, @hallaji! Thank you for preparing this. I've been busy, so I overlooked this one, my bad.

kettanaito commented 4 years ago

I've updated your feature branch against the latest master. The changes look good to me, let's wait for the CI.