kettanaito / react-advanced-form

Functional reactive forms. Multi-layer validation, custom styling, field grouping, reactive props, and much more.

https://redd.gitbook.io/react-advanced-form

MIT License

217 stars 24 forks source link

Bundle size reduction roadmap #253

Open kettanaito opened 6 years ago

kettanaito commented 6 years ago

Roadmap

Bundling

[ ] Double check that tree shaking is working properly
[ ] Ensure Flow types are stripped in the production bundle
[x] Ensure Ramda methods are imported explicitly, without unnecessary code
[ ] Ensure any kind of useless comments are stripped out in the production bundle

Architecture

[x] Remove ImmutableJS (#272)
[x] Remove invariant from the internal methods
[ ] Replace Form methods with references to composite functions

Vidlec commented 6 years ago

Regarding Ramdas ifElse: https://github.com/ramda/ramda/blob/v0.25.0/source/ifElse.js Not sure if it can be made significantly smaler. Also thats only 1.3kb not minified

kettanaito commented 6 years ago

@Vidlec I've tried replacing Ramda's method with identical one, except those don't have currying, and in average they are at least half smaller the size of the original Ramda methods.

That is, of course, subjective, but I've put it there to be considered.

kettanaito commented 6 years ago

@Vidlec, after some time I also came to conclusion that micro-optimization is not worth it. I would stick with Ramda's functions.

kettanaito commented 6 years ago

Proper imports of ramda (or the usage of babel-pluing-ramda) reduces the library's bundle size by ~50Kb.