search

kettanaito / react-advanced-form

Functional reactive forms. Multi-layer validation, custom styling, field grouping, reactive props, and much more.
https://redd.gitbook.io/react-advanced-form
MIT License
217 stars 24 forks source link

TypeScript type definitions #318

Open kettanaito opened 6 years ago

kettanaito commented 6 years ago

Introduces a basic typings in TypeScript.

Subjected to merge after a prior discussion.

kettanaito commented 6 years ago

What do you think about modularizing type definitions, @ell10t?

lemcii commented 6 years ago

No objections here, if it makes it more manageable it's probably not a bad idea.

kettanaito commented 6 years ago

@ell10t I will try to break it down then.

Apart from that, the only crucial thing that is left is a type definition of that [valuePropName] in various callbacks. Within createField scope it should be possible to do via generics, but I am not sure how to handle it in Form callback methods.

lemcii commented 6 years ago

Alright, if I get time I'll have a look into the generics as well.