search

kettanaito / react-advanced-form

Functional reactive forms. Multi-layer validation, custom styling, field grouping, reactive props, and much more.
https://redd.gitbook.io/react-advanced-form
MIT License
217 stars 24 forks source link

Reactive require not working properly on page load #352

Open ludovitkapusta opened 5 years ago

ludovitkapusta commented 5 years ago

Environment

What

Reactive require not working properly on page load

Current behavior

Required fields resulted from reactive way of deciding if field should be required is affecting only last one field if there is more then one reactive require.

Expected behavior

Required fields are correctly resolved after page load

Why

It looks like that reactive conditions are run only on last field that use reactive require

How

You have two inputs, two checkboxes. First input should be required if first checkbox is checked, second input should be required if second checkbox is checked. https://codesandbox.io/s/pp1l8j2j90 when you press submit, only one checkbox is required, should be both

kettanaito commented 5 years ago

This is the issue of concurrent field updates, when both fieldA and fieldB are setting its property to the next value simultaneously. I've solved this previously, but this issue proves it's still doesn't work properly at some cases.

kettanaito commented 5 years ago

Thanks for reporting. This will be covered with the chunked state updates feature.

I'm testing the proof of concept, and it eliminates this issue. Please await for the responsive pull request.