kettanaito / react-advanced-form

Functional reactive forms. Multi-layer validation, custom styling, field grouping, reactive props, and much more.

https://redd.gitbook.io/react-advanced-form

MIT License

217 stars 24 forks source link

Closed redraushan closed 5 years ago

redraushan commented 5 years ago

Closes #357

Roadmap

[x] Whenever a field is created without a Form passed to it through the context, a meaningful error must be displayed in the console
[x] The rendering of the page must not be blocked; formless field returns null from its render method.

redraushan commented 5 years ago

Hi @kettanaito please review :)

_{Sent with GitHawk}

kettanaito commented 5 years ago

First of all, thank you for the first contribution, @redraushan!

Sorry it took me some time to get to your pull request. Looks great overall. Could you please see my comments?

kettanaito commented 5 years ago

Thank you and welcome your first contribution, @redraushan! 🎉 Your changes are approved and merged.

There is always some task that needs help, and I am glad to discuss things with you. You can use this invite to have a chat with me on discord.