kettanaito / react-advanced-form

Functional reactive forms. Multi-layer validation, custom styling, field grouping, reactive props, and much more.
https://redd.gitbook.io/react-advanced-form
MIT License
217 stars 24 forks source link

"react-advanced-form@1.7.2" has incorrect peer dependency "react@^15.0.0" #409

Open renepardon opened 4 years ago

renepardon commented 4 years ago

Is this project still maintained? If so, could you please update the peer dependency to latest react version to hide this warning during application build?

kettanaito commented 4 years ago

Hey, @renepardon. I'm currently not working on this project (see the status update), but critical issues and vulnerabilities should be fixed even in this mode.

Do you mind shipping that dependency version bump in a pull request? If there's any build/test failures I'll gladly help to resolve them. Thanks.

ajschlosser commented 3 years ago

@kettanaito If @renepardon has not yet I would be happy to oblige

kettanaito commented 3 years ago

Hey, @ajschlosser. That would be great, I could use some help with this issue. Let me know if you need any help in preparing a pull request. Thank you!

Asher978 commented 3 years ago

This is still an issue

$ npm install react-advanced-form --save
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: aisg-support@1.0.0
npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   react@"^16.8.6" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0" from react-advanced-form@1.7.2
npm ERR! node_modules/react-advanced-form
npm ERR!   react-advanced-form@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\ashaheen\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\ashaheen\AppData\Local\npm-cache\_logs\2021-03-25T15_35_11_599Z-debug.log