search

kettari / authgoogle

Google Authentication Plugin for DokuWiki
13 stars 17 forks source link

Redirect to desired page after login/reauth. #35

Closed ATMartin closed 7 years ago

ATMartin commented 8 years ago

Currently, if a user clicks on a link into a Dokuwiki using this plugin and they're not logged in, they're forced to the start route after login. This means the user needs to click the link, then log in, then go back and click the link again to get to their intended destination.

This patch corrects this by persisting the referer from our login page so that users are redirected to their intended destination after logging in.

Been a while since I PHP'ed - comments/criticism welcome. :) Thanks for this plugin!

tysoncecka commented 8 years ago

Line 71 is missing an ending )

ATMartin commented 8 years ago

Whoops, thanks @tysoncecka! Got it closed up now.

wpg4665 commented 8 years ago

2 questions:

Where are you in regards to this PR being applied, because it's sorely needed =) And,

How do we address the, essentially infinite, extra redirect URIs on the Cloud Platform credentials settings? Or does simply leaving the list blank allow for redirects ANYWHERE?

rposborne commented 7 years ago

@kettari Is there any way this could be merged?

kettari commented 7 years ago

@rposborne merged. Could you let me know if some undesired behaviour will show up, please?