search

kettari / authgoogle

Google Authentication Plugin for DokuWiki
13 stars 17 forks source link

Adjust method signatures to match parent #36

Open splitbrain opened 8 years ago

splitbrain commented 8 years ago

Starting with PHP 7, classes that overide methods from their parent have to match their parent's method signature regarding type hints. Otherwise PHP will throw an error.

Your plugin seems not to match DokuWiki's method signatures causing it to fail under PHP7. This patch tries to fix that.

Please note that this patch and the resulting pull request were created using an automated tool. Something might have gone, wrong so please carefully check before merging.

If you think the code submitted is wrong, please feel free to close this PR and excuse the mess.

Rvice commented 6 years ago

This was already addressed https://github.com/kettari/authgoogle/commit/86dd51cbe67da9c8566f520078249b9d3fc9c834