search

kettingpowered / Ketting-1-20-x

A fork of MinecraftForge with added Bukkit & Spigot patches
Other
60 stars 14 forks source link

Fix sweep attack enchantment #288

Closed sj-hub9796 closed 1 week ago

sj-hub9796 commented 1 week ago

I'm surprised no one knew about this since Ketting released it LMAO

JustRed23 commented 1 week ago

What does this fix exactly?

sj-hub9796 commented 1 week ago

This pr only renames f4 to f3? Why?

when i attack iron golem(he has 50 health) and give damage to surround entities with sweep attack(sharpness 5, sweep attack 3 levels.) on normal spigot: image

also on ketting: image

problem is damage dealt by the sweep attack is proportional to the health of the entity being attacked.

JustRed23 commented 1 week ago

This pr only renames f4 to f3? Why?

when i attack iron golem(he has 50 health) and give damage to surround entities with sweep attack(sharpness 5, sweep attack 3 levels.) on normal spigot: image

also on ketting: image

problem is damage dealt by the sweep attack is proportional to the health of the entity being attacked.

A variable name change won't fix that xD

C0D3-M4513R commented 1 week ago

How about you change the wrong f3 instance to f4 then? (instead of all instances of f3 to f4)