Corail Tombstone not working enchantments

MrMalkova commented 2 months ago

Basic questions:

[X] I am actually using ketting, and not any other software (e.g. magma)
[X] I am using the latest Ketting version at the time of writing for the Minecraft version, that I am using
[x] I have provided full server logs and not a crash-report
[ ] I have checked all items without reading.
[X] I have provided proper reproduction steps
[ ] I have ticked all boxes

What Minecraft Version is your Server on?

1.20.1

Full Ketting Version

1.20.1-47.3.6-0.3.22

Description of behavior

I've encountered this bug a few weeks ago and the bad thing about all is that it also happens in other hybrid servers like Mohist, Arclight, etc.. I also tried in Ketting but the issue still remains. Of course the author of the mod does not have the problem since it works on a normal Forge server. Neither do the Ketting developers since it is very difficult to make this type of Forge+plugins servers always work. Anyways, I saw that recently was reported an issue with this mod (but with the gravestone keys). In my case I have to say that I didn't encountered that bug in a lot of hours of playing in my server. Likewise, I have taken the opportunity to post this problem since it would be incredible to be able to make it work.

Reproduction Steps

Steps to reproduce the behavior:
1. Install latest version of Corail Tombstone for 1.20.1. (The version of the mod is 8.7.0)
2. Run the server and client only with this mod.
3. Use an anvil and put a sword with each of the following enchantments (Frostbite X, Magic Siphon X and Plague Bringer X)
4. Check them by trying to kill a mob. There you can see that none of them work. (Only the armor ones work)

Logs

https://mclo.gs/wEPqPND

(No console report, no crash. Just me checking the enchantments with an Iron Golem)

Additional context

Sorry if the video has some black screens, it's my pc fault. https://i.imgur.com/CkPBF6t.mp4

JustRed23 commented 2 months ago

Please ignore these people promising a fix as a zip file, or as any file... These are all spam bots that are sending malware

Corail31 commented 2 months ago

@MrMalkova Can you contact me on CurseForge to provide you a "test" version with a different mixin ? (as i only see this on my side and i wasn't aware of a weapon enchantment issue with Hybrid Server).

MrMalkova commented 2 months ago

@Corail31 Of course I can

C0D3-M4513R commented 2 months ago

@Corail31 If a mixin is failing on Ketting that succeeds on Forge, we will try to make it work/compatible (as in that case it's clearly a ketting issue).

JustRed23 commented 2 months ago

It's a bit harder to diagnose due to the mod being closed source, but I'll find a way

MrMalkova commented 2 months ago

I can confirm that the issue is now fixed.

Corail31 commented 2 months ago

Good bet so, i was using a not strong enough mixin so i'll fix it on my side in the next release (no need to change Ketting).

C0D3-M4513R commented 2 months ago

It's a bit harder to diagnose due to the mod being closed source, but I'll find a way

Just use recaf and apply srg->moj mappings. you have a mostly readble mod now, provided that no anti-obfuscation was used.

(Or just apply FART and open in sny decompiler really.) (recaf also decompiles)

Corail31 commented 2 months ago

@C0D3-M4513R the best way is to ask me how it works on CurseForge or here.

C0D3-M4513R commented 2 months ago

I meant that as a general way for closed source mods, as there are a couple. (I even manually patched some mods for some servers.)

kettingpowered / Ketting-1-20-x