SkinsRestorer | The issue where the items of mods that support curios mod do not appear after using the /skin set command

TeQTabanca commented 1 month ago

Basic questions:

[X] I am actually using ketting, and not any other software (e.g. magma)
[X] I am using the latest Ketting version at the time of writing for the Minecraft version, that I am using
[ ] I have provided full server logs and not a crash-report
[ ] I have checked all items without reading.
[X] I have provided proper reproduction steps
[ ] I have ticked all boxes

What Minecraft Version is your Server on?

1.20.1

Full Ketting Version

1.20.1-47.3.6-0.3.25

Description of behavior

After using the /skin set command in the SkinsRestorer plugin, items from mods that support curios mod do not appear.

Curios API, SkinsRestorer, Tool Belt (I added Tool Belt mod because it works with Curios mod.)

Reproduction Steps

Steps to reproduce the behavior:
1. Install Curios API and Tool Belt mod.
2. Install the SkinsRestorer plugin.
3. Run the server and enter
4. /skin set <any player's name>

Logs

There are no errors in the server console

Additional context

My guess is that the SkinsRestorer plugin may not be seeing items similar to the Tool Belt mod when renewing the player's skin. That's why items may not appear. (I installed an alternative mod of the Curios API mod. Items continued to appear after using the /skin set command. So the problem seems to be in Curios API mod.)

Alternative Curios API mod: Accessories (Curios Compatibility Layer Required!)

p0t4t0sandwich commented 1 month ago

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

TeQTabanca commented 1 month ago

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

I'm already trying it on the server. It doesn't give any errors.

TeQTabanca commented 1 month ago

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.

[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count

C0D3-M4513R commented 1 month ago

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.
[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count

If what I think what is happening is happpening (which is that SkinsRestorer effetively completely clears the inv and re-gives you the items later), then we can't fix this.

Also that is why we always ask for logs.

TeQTabanca commented 1 month ago

Have you tried replicating the issue on an online server? (You should also provide logs regardless of whether you see errors, because there is always useful contextual info)

When I equip or remove items from mods that support the Curios API mod, it gives an error in the console.
[20:16:37] [Server thread/ERROR] [or.bu.in.InventoryView/]: Slot 49 greater than inventory slot count
If what I think what is happening is happpening (which is that SkinsRestorer effetively completely clears the inv and re-gives you the items later), then we can't fix this.

Also that is why we always ask for logs.

The problem is that I only install and try the problematic mods on the test server and the text I sent you does not appear, but the problem still persists.

Logs (Skinrestorer plugin's debug mode is on!)

TeQTabanca commented 1 month ago

I presented a mod similar to the curios API mod I mentioned above. When using that mod, wings, belts, etc. appear after typing the /skin set command. My guess is that the curios api cannot register the items connected to the curios api mod to the bukkit item api.

C0D3-M4513R commented 1 month ago

My best guess is that curios just doesn't properly update the inventory size or uses a different internal inventory.

This is not looking like something we can fix.

JustRed23 commented 1 day ago

SkinRestorer is known to break curios, the same thing happened on Magma, there unfortunately is no fix for this other than remove the plugin

kettingpowered / Ketting-1-20-x