kettle11 / kapp

A pure Rust window and input library for Windows, Mac, and Web. (Work in progress)
Apache License 2.0
56 stars 4 forks source link

Add IME support for Windows #65

Closed lunabunn closed 3 years ago

lunabunn commented 3 years ago

See https://github.com/kettle11/kapp/issues/64 for additional details

lunabunn commented 3 years ago

Note that this only implements IME events. Functionality to set the location of IME candidate lists is not yet exposed (mainly because I myself don't have a usecase for it).

lunabunn commented 3 years ago

Changed all return values to 0 as I couldn't find any documented differences. Also added (Input Method Editor) to the docs for Event::IMEComposition. One wouldn't really be using Event::IMEEndComposition without first using Event::IMEComposition, so I think that should be fine.

lunabunn commented 3 years ago

@kettle11 Sorry, I guess I'm way too sleepy right now to code properly😅 Everything should be good now, this time for real! (at least I hope)

kettle11 commented 3 years ago

I can relate. Half of kapp's comments are so I can partially understand later when I'm sleepy. Get some rest!

This looks great though! I'll merge this now.

(Thought I still think there might be a tiny bug with the ImmReleaseContext spot, but we can catch it in a follow-up)