search

kevalpatel2106 / android-ringtone-picker

Simple Ringtone Picker dialog which allows you to pick different sounds from ringtone, alarm tone, notification tone and music from external storage.
Apache License 2.0
73 stars 25 forks source link

"Play ringtone" does not work #1

Closed MarcinOrlowski closed 7 years ago

MarcinOrlowski commented 7 years ago

"Play ringtone" in demo app does not seem to cause any effects and app stays quiet in both picker and after selection.

kevalpatel2106 commented 7 years ago

@MarcinOrlowski Did you enabled Play Ringtone switch?

MarcinOrlowski commented 7 years ago

Yes, no difference it was on or off

egoliveira commented 7 years ago

I had the same issue. I believe you have to reset the media player regardless if you are playing a media file or not.

RingTonePlayer.java, lines 36-39:

if (mMediaPlayer.isPlaying()) {
    mMediaPlayer.stop();
}

mMediaPlayer.reset();
jishindev commented 7 years ago

Crashed when clicking on a different item in the list.

As @egoliveira mentioned, you should be resetting the media player every time.

Stacktrace - 

 java.lang.IllegalStateException
                      at android.media.MediaPlayer._setDataSource(Native Method)
                      at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1128)
                      at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1113)
                      at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1010)
                      at android.media.MediaPlayer.setDataSource(MediaPlayer.java:968)
                      at com.kevalpatel.ringtonepicker.RingTonePlayer.playRingtone(RingTonePlayer.java:41)
                      at com.kevalpatel.ringtonepicker.RingtonePickerDialog$2.onClick(RingtonePickerDialog.java:157)
                      at android.support.v7.app.AlertController$AlertParams$3.onItemClick(AlertController.java:1045)
                      at android.widget.AdapterView.performItemClick(AdapterView.java:310)
                      at android.widget.AbsListView.performItemClick(AbsListView.java:1145)
                      at android.widget.AbsListView$PerformClick.run(AbsListView.java:3066)
                      at android.widget.AbsListView$3.run(AbsListView.java:3903)
                      at android.os.Handler.handleCallback(Handler.java:739)
                      at android.os.Handler.dispatchMessage(Handler.java:95)
                      at android.os.Looper.loop(Looper.java:148)
                      at android.app.ActivityThread.main(ActivityThread.java:5417)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
kevalpatel2106 commented 7 years ago

This issue is fixed. Fix will be available in next release.

kevalpatel2106 commented 7 years ago

This issue is fixed in v1.1.