search

kevaundray / neo-go

Modular Implementation of the node in Golang
0 stars 0 forks source link

Review of the Wire Protocol #18

Open kevaundray opened 6 years ago

kevaundray commented 6 years ago

The wire protocol is now usable, however there are still things that I believe need to be implemented, some now and some further down the line:

MSGPING, MSGPONG: These will be used to verify that the node is still alive without having to do the handshake with it.

MSGReject: This is an important message for those looking to debug code, instead of silently disconnecting. The node will send a MSGReject stating why he has rejected the request.

MSGFilters: These will be implemented later down the line when either GCS/Bloom has been made.

This package has been designed so that the inner workings can be easily changed without the outsider having to edit their code if they rely upon it. I believe that optimisations can always be made and so this package should be visited periodically to review, add more tests and optimise.

kevaundray commented 6 years ago

Periodic Review:

The wire protocol is now usable and has been tested in a seed node implementation. In the future, it may refactored to allow versioning using go mod.