Changed date_of_dissolution to date_of_cessation

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API

MIT License

37 stars 44 forks source link

Changed date_of_dissolution to date_of_cessation #106

Closed adancy closed 5 years ago

adancy commented 5 years ago

The field date_of_dissolution doesn't actually exist in the company profile JSON . The correct field to use is date_of_cessation .

kevbite commented 5 years ago

Hey, Thanks for the PR, looks like we've got 1 failing test on the build - https://ci.appveyor.com/project/kevbite/companieshouse-net/builds/22519379/tests

Do you mind trying to take a look?

Thanks.

adancy commented 5 years ago

I need to download and try building it locally, there's obviously a test I've missed and monkey-patching the files directly on GitHub isn't doing the trick. I'll try to look at this tomorrow.

kevbite commented 5 years ago

Just had few mins and fixed up the tests... hopefully will pass this time around 👍