kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Officer Summary always null #13

Closed turowicz closed 8 years ago

turowicz commented 8 years ago

The library is not retrieving Officer Summary or the Officer list.

@kevbite are you guys aware of this?

turowicz commented 8 years ago

I'm going to add it - should it be a separate client or another HTTP call in the Profile client?

kevbite commented 8 years ago

Looks like it should be pulled with the company profile - officer_summary - https://developer.companieshouse.gov.uk/api/docs/company/company_number/companyProfile-resource.html Feel free to add it if its not included.

There is however a officers list which has more details - https://developer.companieshouse.gov.uk/api/docs/company/company_number/officers/officerList.html

turowicz commented 8 years ago

@kevbite added the /officers endpoint - it is always guaranteed to return data while company profile's officer summary is optional.

kevbite commented 8 years ago

I'm busy in meetings all afternoon but I've got @Blundell89 to check this over and merge it in for you.

turowicz commented 8 years ago

thanks!