kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

PersonWithSignificantControl misses property Identification #155

Closed alexmohr1966 closed 2 years ago

alexmohr1966 commented 3 years ago

When a PSC is of kind "corporate-entity-person-with-significant-control" essential information to identify the company is transferred within in the property "identification". Unfortunately this is not mapped in the class PersonWithSignificantControl. Here we would need to add

  [JsonProperty(PropertyName = "identification")]
  public PersonWithSignificantControlIdentification Identification { get; set; }

referencing a new class

    public class PersonWithSignificantControlIdentification
    {
        [JsonProperty(PropertyName = "legal_authority")]
        public string LegalAuthority { get; set; }

        [JsonProperty(PropertyName = "legal_form")]
        public string LegalForm { get; set; }

        [JsonProperty(PropertyName = "place_registered")]
        public string PlaceRegistered { get; set; }

        [JsonProperty(PropertyName = "registration_number")]
        public string RegistrationNumber { get; set; }
    }

Thank you for your consideration.

kevbite commented 3 years ago

Hey @alexmohr1966, Thanks for highlighting this issue, we'll sort this out for you as soon as possible.

alexmohr1966 commented 3 years ago

Great, thanks @kevbite . As you will see, I have missed one property under Identification

        [JsonProperty("country_registered")]
        public string CountryRegistered { get; set; }