kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

New FilingCategory enum values #209

Closed shandybob76 closed 8 months ago

shandybob76 commented 8 months ago

Hi,

I've been using your CompaniesHouse.NET implementation, and pulled in a load of company profiles, however there are a few which do not deserialize due to missing FilingCategory values;

"officers" plural seems to exist, but some companies come back with "officer" singular.

I'll add these into a branch and PR it over for your consideration.

Cheers

Rob.

shandybob76 commented 8 months ago

Note "social-landlord" is missing on FilingSubcategory too.

shandybob76 commented 8 months ago

Example company numbers

kevbite commented 8 months ago

Hey @shandybob76 thanks for raising the issue, we'll try fix this ASAP unless you fancy submitting a PR to us?

shandybob76 commented 8 months ago

Hi @kevbite - I just pushed the PR for your consideration, cheers

shandybob76 commented 8 months ago

It's a shame Companies House don't have a definitive list! The docs are a little out of date that they have here

https://developer-specs.company-information.service.gov.uk/companies-house-public-data-api/resources/filinghistoryitem?v=latest

kevbite commented 8 months ago

@shandybob76 we've always had that problem, we've hit enum values that haven't even been listed for 6+ months before. As originally we did think about pulling their list and building it always with the latest list but that's impossible as they don't declare them all.

kevbite commented 8 months ago

I've merged in the PR and is released in 8.0.29

Thanks!