search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Added missing enum mappings #55

Closed faesel closed 7 years ago

faesel commented 7 years ago

The company 00117548 was using FilingCategory's not captured in the Enum list causing conversion errors. I have added in the missing values.

faesel commented 7 years ago

Looks like appveyor is failing because there is no api key, as I dont want to insert my personal one could you please provide some guidance on how i can make the build go green?

kevbite commented 7 years ago

That's a little odd, It should be pulling though from this encrypted variable https://github.com/kevbite/CompaniesHouse.NET/blob/master/appveyor.yml#L29

kevbite commented 7 years ago

Oh seems this has changed https://www.appveyor.com/docs/build-configuration/#secure-variables

However, secure variables are not decoded during Pull Request builds which prevents someone from submitting PR with malicious build script displaying those variables. In more controlled environment through with a trusted team and private GitHub repositories there is an option on General tab of project settings to allow secure variables for PRs.

and the setting has a new description image

I'll merge it in, and our tests will run though the normal process. I have however opened up a new issue to look at this #56.