search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Implement Filings #6

Closed turowicz closed 8 years ago

turowicz commented 8 years ago

Ability to list all filings with appropriate descriptions from:

https://github.com/companieshouse/api-enumerations/blob/master/filing_history_descriptions.yml

kevbite commented 8 years ago

Hello, Listing the filing history seems fine but not sure we should be putting UI concerns within this API wrapper, these should be implemented in your UI layer based on the enum values that the wrapper returns. If you think about localization then this makes more sense to be in the UI layer within your application.

turowicz commented 8 years ago

@kevbite you are absolutely right - I meant the API call to get the filings. Actual descriptions are linked for reference (so we don't forget to use them in UI)

turowicz commented 8 years ago

Have a look at my PR, it probably makes more sense.

turowicz commented 8 years ago

PR #7 all ready to be accepted so this can be resolved