search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Unhandled FilingCategory value `persons-with-significant-control` #61

Closed conficient closed 7 years ago

conficient commented 7 years ago

Test failed for 03977902, unhandled category:

Test Name:  ThenTheDataItemsAreNotEmpty
Test FullName:  CompaniesHouse.IntegrationTests.Tests.CompanyFilingHistoryTests.CompanyFilingHistoryTestsValid("03977902").ThenTheDataItemsAreNotEmpty
Test Source:    C:\Users\Howard\Documents\GitHub\CompaniesHouse.NET\src\CompaniesHouse.IntegrationTests\Tests\CompanyFilingHistoryTests\CompanyFilingHistoryTestsValid.cs : line 47
....
Newtonsoft.Json.JsonSerializationException : Error converting value "persons-with-significant-control" to type 'CompaniesHouse.Response.FilingCategory'. Path 'items[0].category', line 1, position 325.
  ----> System.ArgumentException : Requested value 'persons-with-significant-control' was not found.

I will be submitting a pull request to fix this.

kevbite commented 7 years ago

Fixed part of CompaniesHouse 3.2.1 Release.