search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Would it be possible to extend the Officer class so that I can get the nationality #84

Closed JulianGuppy closed 6 years ago

JulianGuppy commented 6 years ago

Proposed:- In Officer.cs

    [JsonProperty(PropertyName = "nationality")]
    public string Nationality { get; set; }

I need to know the nationality of a director as part of the verification KYC/AML on my project so this would be very handy.

Regards Julian

kevbite commented 6 years ago

Hello, Sounds perfectly fine, It looks like they've added a bunch of new properties to the Officers response since last time I had a look -https://developer.companieshouse.gov.uk/api/docs/company/company_number/officers/officerList-resource.html

Also, I've noticed that they don't return a officers overview anymore on the companies profile response - https://developer.companieshouse.gov.uk/api/docs/company/company_number/companyProfile-resource.html

I'd like to get these tired up too as they're quite related. Thanks for submitting the PR #85 I'll take a look tonight after I've finished work and at least get that bit of functionality merged it before tomorrow.

Cheers

kevbite commented 6 years ago

Changes have been included and will be in release 6.0.0