kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Targeting Hell #9

Closed turowicz closed 8 years ago

turowicz commented 8 years ago

Unfortunately my clients are using various versions of .NET and this library only targets 4.5.1.

This issue is to create targets for 4.5, 4.6, and Core (at least).

All files to be included in a single nuget package.

References: http://blog.marcgravell.com/2015/11/the-road-to-dnxpart-3.html https://stackoverflow.com/questions/34611829/how-to-package-a-net-framework-library

turowicz commented 8 years ago

@kevbite if I create a PR with necessary changes, would you do the Appveyor side?

kevbite commented 8 years ago

That's fine, If i remember its a lot hard than it looks from the cover as you also need to re-target the nuget packages being used within the project.

Would a interim release of just knocking down the framework to 4.5 work for you?

turowicz commented 8 years ago

Yes - that would be great!

I would save me today :)

side note: a single nuget package can have multiple versions of the library inside, it's supported out of the box, the real problem is producing those dlls. I may have some time over the weekend to do that but knocking the version down do 4.5 would save me today.

kevbite commented 8 years ago

I'll sort out bumping down to version 4.5 within the next hour.

turowicz commented 8 years ago

@kevbite done - check it out in PR

kevbite commented 8 years ago

OK cheers