search

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.
MIT License
52 stars 28 forks source link

Feature/click outside to side no closey #15

Closed kevcjones-archived closed 6 years ago

kevcjones-archived commented 6 years ago

This resolves #14 but still leaves the component implementation agnostic.

Decided it was semantically readable to pass in a className instead of making the process require 2 config additions.

kevcjones-archived commented 6 years ago

Probably yeah, bloody thing suggests you commit it, but it causes no ends of problems. Will make that change later, for now delete it

On 17 Dec 2017 12:54, "Celso Trindade" notifications@github.com wrote:

@celsomtrindade commented on this pull request.

The file package-lock.json (both on src and demo) is back at the code.

Isn't it better to ignore it on the .gitignore file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/pull/15#pullrequestreview-83999572, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqe8JFb6i9P019s-4Gq_NSz1CqdzEoeks5tBQ7vgaJpZM4REoiu .

kevcjones-archived commented 6 years ago

Removed the lock files, do you have any qualms with the enhancement? I don't, its better than hard coding the expectation that the first child is the click blocking entity OR putting in bootstrap classes.