Doesn't work in Angular 8.1 --prod mode

kevcjones / ngx-simple-modal

A simple unopinionated framework to implement simple modal based behaviour in angular (v2+) projects.

MIT License

52 stars 27 forks source link

Doesn't work in Angular 8.1 --prod mode #54

Closed energY8989 closed 5 years ago

energY8989 commented 5 years ago

I receive an error when i build with --prod option. Without, it works. I am getting the following Java-Script errormessage:

"this.viewContainer is undefined"

vladk commented 5 years ago

I have same error

kevcjones-archived commented 5 years ago

Yeah I've seen it, working on it now.

On Tue, 9 Jul 2019, 15:07 Vlad K, notifications@github.com wrote:

I have same error

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/KevCJones/ngx-simple-modal/issues/54?email_source=notifications&email_token=AAFJ54HXCADTMIH4QZIBFP3P6SLTJA5CNFSM4H7FO342YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQMDMQ#issuecomment-509657522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFJ54B7EPSYMISU4BT3SGDP6SLTJANCNFSM4H7FO34Q .

kevcjones-archived commented 5 years ago

Thanks for the heads up - ironically we were about to push our own work into production and 15 minutes later as we hit smoke tests in our staging production server, the same messages hit my inbox.

Fixed in 1.3.15 - I've left the demo-ng8 in --prod mode for anyone who wants to see it working.

It always pays to test in prod mode as well 🤦‍♂ but it's been a while since I've had a prod specific issue.